Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes another issue in binary matthews corr coef #1863

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jun 28, 2023

What does this PR do?

Fixes #1829

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1863.org.readthedocs.build/en/1863/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jun 28, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1863 (3049513) into master (372f22e) will decrease coverage by 37%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1863     +/-   ##
========================================
- Coverage      87%     50%    -37%     
========================================
  Files         258     258             
  Lines       14591   14591             
========================================
- Hits        12766    7337   -5429     
- Misses       1825    7254   +5429     

@mergify mergify bot added the ready label Jun 28, 2023
@SkafteNicki SkafteNicki enabled auto-merge (squash) June 29, 2023 11:18
@SkafteNicki SkafteNicki merged commit d2d346c into master Jun 30, 2023
60 checks passed
@SkafteNicki SkafteNicki deleted the bugfix/bmmc branch June 30, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinaryMatthewsCorrCoef implementation for extreme cases is wrong
3 participants