Fix prefix/postfix interaction between MetricCollection and ClasswiseWrapper
#1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1918 +/- ##
========================================
- Coverage 85% 40% -45%
========================================
Files 263 263
Lines 15087 15087
========================================
- Hits 12833 6079 -6754
- Misses 2254 9008 +6754 |
Borda
approved these changes
Jul 13, 2023
|
@SkafteNicki Thank you for working on this fix! @justusschock @stancld Is there a timeline for when this bug fix will be reviewed? |
stancld
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1915
The introduction of
prefix/postfix(introduced here #1866) arguments inClasswiseWrapperhad some untested interaction with the same arguments inMetricCollection, that leads to the wrong result. PR fixes this with a simple internal renaming and add test.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1918.org.readthedocs.build/en/1918/