Fix MetricCollection when input are metrics that return dicts with same keywords
#2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
justusschock,
Borda and
stancld
as code owners
Borda
reviewed
Aug 27, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Borda
approved these changes
Aug 28, 2023
justusschock
approved these changes
Aug 28, 2023
|
@SkafteNicki I believe this is just not updated yet... |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2027 +/- ##
======================================
Coverage 87% 87%
======================================
Files 277 277
Lines 15730 15746 +16
======================================
+ Hits 13642 13657 +15
- Misses 2088 2089 +1 |
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
…same keywords (Lightning-AI#2027) Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2020
Currently if metric collection have multiple metrics in the collection that returns dicts and some of the keys in those dicts are the same, it only returns the results of the last metric (because it is overwriting the key). Fixes this.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2027.org.readthedocs.build/en/2027/