Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: Calinski Harabasz Score #2036

Merged
merged 16 commits into from
Sep 4, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 30, 2023

What does this PR do?

Fixes part of #2003

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2036.org.readthedocs.build/en/2036/

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2036 (5af6580) into master (c139a96) will increase coverage by 0%.
The diff coverage is 89%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2036   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         279     281    +2     
  Lines       15828   15884   +56     
======================================
+ Hits        13731   13781   +50     
- Misses       2097    2103    +6     

@mergify mergify bot removed the has conflicts label Sep 1, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 1, 2023
@SkafteNicki SkafteNicki mentioned this pull request Sep 4, 2023
4 tasks
@SkafteNicki SkafteNicki merged commit b10cc2f into master Sep 4, 2023
66 checks passed
@SkafteNicki SkafteNicki deleted the newmetric/calinski_harabasz_score branch September 4, 2023 13:30
matsumotosan added a commit to matsumotosan/metrics that referenced this pull request Sep 4, 2023
* docs

* functional

* module

* tests

* changelog

* try another link

* mypy

* remove broken link

* change image

* use new inputs

* fix

* fix flaky tests

---------

Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Sep 19, 2023
* docs

* functional

* module

* tests

* changelog

* try another link

* mypy

* remove broken link

* change image

* use new inputs

* fix

* fix flaky tests

---------

Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants