Improve numeric stability of LPIPS
#2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2144 +/- ##
========================================
- Coverage 87% 40% -46%
========================================
Files 293 293
Lines 16371 16371
========================================
- Hits 14230 6626 -7604
- Misses 2141 9745 +7604 |
Borda
approved these changes
Oct 5, 2023
stancld
approved these changes
Oct 5, 2023
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Oct 14, 2023
* improve stability * changelog
Borda
pushed a commit
that referenced
this pull request
Nov 30, 2023
Borda
pushed a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2139
Instead of doing
sqrt(x) + epsin one of the operations involved in lpips it will now besqrt(x+eps)which is more numerical stable for small values.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2144.org.readthedocs.build/en/2144/