Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confidence scores when extended_summary=True in MeanAveragePrecision #2212

Merged
merged 10 commits into from
Nov 24, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 14, 2023

What does this PR do?

Fixes #2202

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2212.org.readthedocs.build/en/2212/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Nov 14, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2212 (01e9855) into master (9dd199a) will decrease coverage by 50%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2212     +/-   ##
========================================
- Coverage      87%     37%    -50%     
========================================
  Files         293     293             
  Lines       16425   16425             
========================================
- Hits        14278    6031   -8247     
- Misses       2147   10394   +8247     

@SkafteNicki SkafteNicki self-assigned this Nov 14, 2023
@Borda Borda enabled auto-merge (squash) November 14, 2023 17:27
@mergify mergify bot added the ready label Nov 14, 2023
@Borda Borda requested a review from a team November 15, 2023 10:12
@mergify mergify bot removed the has conflicts label Nov 21, 2023
@Borda Borda merged commit 9c964ec into master Nov 24, 2023
59 of 61 checks passed
@Borda Borda deleted the map_confidence_scores branch November 24, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get confidence scores when using extended_summary with MeanAveragePrecision
4 participants