Fix dim_zero_cat reduction
#2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Lightning-AI#2225 by changing "reduced = global_state + local_state" to "reduced = torch.cat([global_state, local_state]
jankng
requested review from
SkafteNicki,
justusschock,
Borda and
lantiga
as code owners
SkafteNicki
approved these changes
Nov 23, 2023
Borda
changed the title
Borda
approved these changes
Nov 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2226 +/- ##
======================================
- Coverage 87% 87% -0%
======================================
Files 293 293
Lines 16423 16425 +2
======================================
+ Hits 14278 14279 +1
- Misses 2145 2146 +1 |
Borda
pushed a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> (cherry picked from commit 9652899)
Borda
pushed a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> (cherry picked from commit 9652899)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2225 by changing "reduced = global_state + local_state" to "reduced = torch.cat([global_state, local_state]
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2226.org.readthedocs.build/en/2226/