Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric tracker #238

Merged
merged 36 commits into from
Aug 4, 2021
Merged

metric tracker #238

merged 36 commits into from
Aug 4, 2021

Conversation

rajs96
Copy link
Contributor

@rajs96 rajs96 commented May 9, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Adds timeseries metric to the library. Resolves #180

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 9, 2021

Codecov Report

Merging #238 (f4a5205) into master (b487ac3) will decrease coverage by 0.05%.
The diff coverage is 91.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   96.01%   95.96%   -0.06%     
==========================================
  Files         126      127       +1     
  Lines        4088     4134      +46     
==========================================
+ Hits         3925     3967      +42     
- Misses        163      167       +4     
Flag Coverage Δ
Linux 74.77% <80.85%> (+0.08%) ⬆️
Windows 74.77% <80.85%> (+0.08%) ⬆️
cpu 74.77% <80.85%> (+0.08%) ⬆️
gpu 95.96% <91.48%> (-0.06%) ⬇️
macOS 74.77% <80.85%> (+0.08%) ⬆️
pytest 95.96% <91.48%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/wrappers/tracker.py 91.11% <91.11%> (ø)
torchmetrics/__init__.py 100.00% <100.00%> (ø)
torchmetrics/wrappers/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b487ac3...f4a5205. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented May 10, 2021

Hello @rajs96! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-04 09:27:08 UTC

@Borda Borda added this to the v0.4 milestone May 10, 2021
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, but I am basically missing a bit of context.
Could you provide an example on how it is intended to be used

torchmetrics/timeseries.py Outdated Show resolved Hide resolved
torchmetrics/timeseries.py Outdated Show resolved Hide resolved
torchmetrics/timeseries.py Outdated Show resolved Hide resolved
torchmetrics/timeseries.py Outdated Show resolved Hide resolved
torchmetrics/timeseries.py Outdated Show resolved Hide resolved
torchmetrics/timeseries.py Outdated Show resolved Hide resolved
torchmetrics/timeseries.py Outdated Show resolved Hide resolved
torchmetrics/timeseries.py Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented May 10, 2021

@rajs96 mind check comments and then we can turn it to PR (not just draft)

also, you mentioned in #180 to implement multiple metrics, but if this class has metric type as an argument, there is no need for multiple classes, right?

@Borda
Copy link
Member

Borda commented May 10, 2021

@rajs96 could you also add to the PR description add a use-case/application?
after we ll add in the docs anyway 🐰

@Borda Borda requested a review from maximsch2 May 11, 2021 07:39
@Borda
Copy link
Member

Borda commented Jun 3, 2021

@rajs96 how is it going here?

@SkafteNicki SkafteNicki linked an issue Aug 3, 2021 that may be closed by this pull request
@Borda Borda modified the milestones: v0.4, v0.5 Aug 3, 2021
@mergify mergify bot added the has conflicts label Aug 4, 2021
@mergify mergify bot removed the has conflicts label Aug 4, 2021
CHANGELOG.md Show resolved Hide resolved
@Borda Borda requested review from SkafteNicki and Borda August 4, 2021 08:37
@Borda Borda enabled auto-merge (squash) August 4, 2021 08:44
@Borda Borda merged commit cd34c84 into Lightning-AI:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Useful abstraction for metrics tracker metrics
4 participants