Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix axis names #2462

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Fix axis names #2462

merged 4 commits into from
Mar 19, 2024

Conversation

baskrahmer
Copy link
Collaborator

@baskrahmer baskrahmer commented Mar 19, 2024

What does this PR do?

Fixes a small bug where the axis labels are not added if the input type is a list instead of a Tensor. I also made the plotting linestyle similar for these two input types.

Part of #2405

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2462.org.readthedocs.build/en/2462/

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #2462 (42f3b3b) into master (9d76f3f) will decrease coverage by 0%.
Report is 27 commits behind head on master.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2462   +/-   ##
======================================
- Coverage      69%     69%   -0%     
======================================
  Files         307     307           
  Lines       17363   17357    -6     
======================================
- Hits        11961   11952    -9     
- Misses       5402    5405    +3     

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls add screenshot before and after? :)

@mergify mergify bot added the ready label Mar 19, 2024
@baskrahmer
Copy link
Collaborator Author

could you pls add screenshot before and after? :)

Sure! Before:
before

After:
after

Negative AUC values are unrelated to my changes, but still a bit strange 😛 can have a look some other time

@Borda Borda merged commit e0f239b into Lightning-AI:master Mar 19, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants