Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list syncronization with partly empty lists #2468

Merged
merged 25 commits into from
Apr 22, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 24, 2024

What does this PR do?

Fixes #2463

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2468.org.readthedocs.build/en/2468/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 24, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Merging #2468 (e4dd328) into master (9d04667) will increase coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2468   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         307     307           
  Lines       17421   17424    +3     
======================================
+ Hits        11995   11998    +3     
  Misses       5426    5426           

@mergify mergify bot removed the has conflicts label Apr 17, 2024
@mergify mergify bot added the ready label Apr 19, 2024
@SkafteNicki SkafteNicki merged commit cd7ccfc into master Apr 22, 2024
62 checks passed
@SkafteNicki SkafteNicki deleted the bugfix/sync_empty_lists branch April 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Metric synchronization fails in corner case
3 participants