-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KLDivergence Metric #247
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 96.64% 96.50% -0.14%
==========================================
Files 107 109 +2
Lines 3428 3491 +63
==========================================
+ Hits 3313 3369 +56
- Misses 115 122 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks like a great start but still needs some more work :]
- Add class interface
- Add test
- Add bindings to
__init__
files - Add documentation
@hassiahk how is it going here, still a draft or ready for full review? |
@Borda, it's been a busy last month for me. I need to add documentation, tests etc, once I am done I will make the PR available for full review. Thanks!! |
that would be great to have it landed :] |
@hassiahk we are aiming at release by end of this week, do you think we can get this land by that time? |
@Borda, really finding it hard to have time and work on this. I will try to complete but can't guarantee yet. |
Hello @hassiahk! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-28 09:59:45 UTC |
Hi @hassiahk, |
I am really sorry for that @SkafteNicki. I was planning to do it today but thank you so much :) |
Do not be sorry, just trying to get some of the PRs done before next release. |
seems that Linux and Windows tests are hanging... |
@Borda should be good now :] |
Before submitting
What does this PR do?
Fixes #66.
PR review
Anyone in the community is free to review the PR tationonce the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
Things to do
This is just for my reference.
__init__
files