Fix incorrect caching of MetricCollection #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update tests to correctly test for Lightning-AI#2211. Also add return deepcopy values of compute
relativityhd
requested review from
SkafteNicki,
justusschock,
Borda,
lantiga and
stancld
as code owners
SkafteNicki
approved these changes
May 30, 2024
|
@SkafteNicki this is everywhere: |
SkafteNicki
requested changes
May 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2571 +/- ##
======================================
- Coverage 69% 69% -0%
======================================
Files 314 314
Lines 17673 17679 +6
======================================
+ Hits 12186 12189 +3
- Misses 5487 5490 +3 |
SkafteNicki
approved these changes
May 31, 2024
Borda
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Fix incorrect caching of MetricCollection Also update tests to correctly test for #2211. Also add return deepcopy values of compute * Update Changelog * fix issues with deepcopy by using .clone --------- Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit 6a23b38)
Borda
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Fix incorrect caching of MetricCollection Also update tests to correctly test for #2211. Also add return deepcopy values of compute * Update Changelog * fix issues with deepcopy by using .clone --------- Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit 6a23b38)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2570. Also provides a better test for #2211. A somewhat larger change is that for this fix (especially the testcases) the compute method needs to return deepcopied values.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2571.org.readthedocs.build/en/2571/