Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how prefix/posfix works in MultitaskWrapper #2722

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 7, 2024

What does this PR do?

Fixes #2656
This should much more closely match how the users expects to these arguments to work.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2722.org.readthedocs.build/en/2722/

@SkafteNicki SkafteNicki added bug / fix Something isn't working enhancement New feature or request labels Sep 7, 2024
@SkafteNicki SkafteNicki added this to the v1.4.x milestone Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 37%. Comparing base (144f6d6) to head (7fc6974).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2722     +/-   ##
========================================
- Coverage      69%     37%    -32%     
========================================
  Files         329     329             
  Lines       18064   18065      +1     
========================================
- Hits        12492    6644   -5848     
- Misses       5572   11421   +5849     

@mergify mergify bot added the has conflicts label Sep 9, 2024
@mergify mergify bot removed the has conflicts label Sep 9, 2024
@mergify mergify bot added the ready label Sep 9, 2024
@Borda Borda merged commit eecc55b into master Sep 10, 2024
62 checks passed
@Borda Borda deleted the bugfix/multitask_postfix_prefix branch September 10, 2024 18:15
Borda pushed a commit that referenced this pull request Sep 11, 2024
* implementation
* tests
* changelog
* fix mypy

(cherry picked from commit eecc55b)
Borda pushed a commit that referenced this pull request Sep 13, 2024
* implementation
* tests
* changelog
* fix mypy

(cherry picked from commit eecc55b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning MultitaskWrapper with postfix parameters results in incorrect dictionary
3 participants