Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corner case in MatthewsCorrcoef #2743

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Fix corner case in MatthewsCorrcoef #2743

merged 4 commits into from
Sep 16, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 14, 2024

What does this PR do?

Fixes #2742

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2743.org.readthedocs.build/en/2743/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Sep 14, 2024
@SkafteNicki SkafteNicki added this to the v1.4.x milestone Sep 14, 2024
@SkafteNicki SkafteNicki self-assigned this Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 41%. Comparing base (62d9d32) to head (0905f43).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2743     +/-   ##
========================================
- Coverage      69%     41%    -28%     
========================================
  Files         329     329             
  Lines       18073   18077      +4     
========================================
- Hits        12499    7479   -5020     
- Misses       5574   10598   +5024     

@mergify mergify bot added the ready label Sep 14, 2024
@Borda Borda force-pushed the master branch 2 times, most recently from d0a5568 to 9fc79ae Compare September 16, 2024 08:18
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 16, 2024
@Borda Borda force-pushed the bugfix/matthews_corrcoef branch 2 times, most recently from d5daecb to 1156e69 Compare September 16, 2024 14:06
@mergify mergify bot removed the ready label Sep 16, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Sep 16, 2024
@mergify mergify bot added the ready label Sep 16, 2024
@Borda Borda merged commit 32290ca into master Sep 16, 2024
62 checks passed
@Borda Borda deleted the bugfix/matthews_corrcoef branch September 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnboundLocalError: local variable 'b' referenced before assignment
2 participants