Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inception Score #299

Merged
merged 18 commits into from
Jun 17, 2021
Merged

Inception Score #299

merged 18 commits into from
Jun 17, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jun 16, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Adds Inception Score (IS) to the new image module
Also added corrected a bit about the FID metric

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #299 (1643af8) into master (1841cad) will increase coverage by 0.04%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   96.37%   96.42%   +0.04%     
==========================================
  Files          96       97       +1     
  Lines        3199     3241      +42     
==========================================
+ Hits         3083     3125      +42     
  Misses        116      116              
Flag Coverage Δ
Linux 76.81% <30.23%> (-0.64%) ⬇️
Windows 76.81% <30.23%> (-0.64%) ⬇️
cpu 76.81% <30.23%> (-19.56%) ⬇️
gpu 96.39% <95.34%> (?)
macOS 76.81% <30.23%> (-19.56%) ⬇️
pytest 96.42% <95.34%> (+0.04%) ⬆️
python3.6 ?
python3.8 ?
python3.9 ?
torch1.3.1 ?
torch1.4.0 ?
torch1.9.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/image/inception.py 94.87% <94.87%> (ø)
torchmetrics/__init__.py 100.00% <100.00%> (ø)
torchmetrics/image/__init__.py 100.00% <100.00%> (ø)
torchmetrics/image/fid.py 82.35% <100.00%> (+0.42%) ⬆️
torchmetrics/functional/regression/spearman.py 97.77% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1841cad...1643af8. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jun 16, 2021

Hello @SkafteNicki! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-17 22:53:32 UTC

tests/image/test_inception.py Outdated Show resolved Hide resolved
tests/image/test_inception.py Outdated Show resolved Hide resolved
tests/image/test_inception.py Outdated Show resolved Hide resolved
torchmetrics/image/inception.py Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki mentioned this pull request Jun 16, 2021
4 tasks
@Borda
Copy link
Member

Borda commented Jun 16, 2021

@SkafteNicki
Copy link
Member Author

@Borda should have been fixed in commit 162d340

@Borda
Copy link
Member

Borda commented Jun 16, 2021

@Borda should have been fixed in commit 162d340

Ok, but would work for v0.2

@Borda Borda enabled auto-merge (squash) June 17, 2021 08:52
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really minor comments. looks good to me

torchmetrics/image/inception.py Outdated Show resolved Hide resolved
torchmetrics/image/inception.py Show resolved Hide resolved
torchmetrics/image/inception.py Outdated Show resolved Hide resolved
torchmetrics/image/inception.py Outdated Show resolved Hide resolved
@Borda Borda merged commit f54ccca into master Jun 17, 2021
@Borda Borda deleted the inception branch June 17, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants