Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code to correspond to equation for matthews_corrcoef #321

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Fix code to correspond to equation for matthews_corrcoef #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b91a028
fix
SkafteNicki Jun 26, 2021
0ba97e0
Update CHANGELOG.md
SkafteNicki Jun 26, 2021
a0e3847
Merge branch 'master' into matthews_formula_fix
mergify[bot] Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- AUC can also support more dimensional inputs when all but one dimension are of size 1 ([#242](https://github.com/PyTorchLightning/metrics/pull/242))
- Fixed `dtype` of modular metrics after reset has been called ([#243](https://github.com/PyTorchLightning/metrics/pull/243))

- Fixed calculation in `matthews_corrcoef` to correctly match formula ([#321](https://github.com/PyTorchLightning/metrics/pull/321))

## [0.3.2] - 2021-05-10

Expand Down
4 changes: 2 additions & 2 deletions torchmetrics/functional/classification/matthews_corrcoef.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@


def _matthews_corrcoef_compute(confmat: Tensor) -> Tensor:
tk = confmat.sum(dim=0).float()
pk = confmat.sum(dim=1).float()
tk = confmat.sum(dim=1).float()
pk = confmat.sum(dim=0).float()
c = torch.trace(confmat).float()
s = confmat.sum().float()
return (c * s - sum(tk * pk)) / (torch.sqrt(s**2 - sum(pk * pk)) * torch.sqrt(s**2 - sum(tk * tk)))
Expand Down