Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-definition found for builtin function #325

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Re-definition found for builtin function #325

merged 2 commits into from
Jun 29, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 28, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jun 28, 2021
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #325 (32bf323) into master (441e116) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         111      111           
  Lines        3547     3547           
=======================================
  Hits         3425     3425           
  Misses        122      122           
Flag Coverage Δ
Linux 75.71% <14.28%> (ø)
Windows 75.71% <14.28%> (ø)
cpu 96.50% <100.00%> (ø)
gpu 96.46% <100.00%> (ø)
macOS 96.50% <100.00%> (ø)
pytest 96.56% <100.00%> (ø)
python3.6 95.62% <100.00%> (ø)
python3.8 96.50% <100.00%> (ø)
python3.9 96.39% <100.00%> (ø)
torch1.3.1 95.62% <100.00%> (ø)
torch1.4.0 95.71% <100.00%> (ø)
torch1.9.0 96.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/collections.py 98.87% <100.00%> (ø)
torchmetrics/image/fid.py 82.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441e116...32bf323. Read the comment docs.

@Borda Borda merged commit 4340f35 into master Jun 29, 2021
@Borda Borda deleted the refactor/build-in branch June 29, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants