Fix OOM in pearson metric #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
justusschock and
tchaton
as code owners
|
Hello @SkafteNicki! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-28 14:47:48 UTC |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
reviewed
Jul 16, 2021
Comment on lines
25
to
30
| mx: Tensor, | ||
| my: Tensor, | ||
| vx: Tensor, | ||
| vy: Tensor, | ||
| cxy: Tensor, | ||
| n: Tensor, |
There was a problem hiding this comment.
can we add a meaning to these vars?
There was a problem hiding this comment.
tried updating the variable names :]
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 96.34% 96.39% +0.05%
==========================================
Files 120 120
Lines 3771 3801 +30
==========================================
+ Hits 3633 3664 +31
+ Misses 138 137 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@SkafteNicki seems that most of the tests are still failing... |
Borda
approved these changes
Jul 24, 2021
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #373
Instead of storing all predictions and target in buffer for pearson correlation, we instead now iteratively update just 6 statistics which will save alot of memory.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃