Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PIT for audio metrics #384

Merged
merged 73 commits into from
Jul 29, 2021
Merged

Add PIT for audio metrics #384

merged 73 commits into from
Jul 29, 2021

Commits on Jul 17, 2021

  1. finish functional version

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    95266f7 View commit details
    Browse the repository at this point in the history

  2. change eval_func to str type

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    3eaf506 View commit details
    Browse the repository at this point in the history

  3. remove return_best_perm

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    f63fedb View commit details
    Browse the repository at this point in the history

  4. raise

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    58dcf1d View commit details
    Browse the repository at this point in the history

  5. PIT

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    bb186d6 View commit details
    Browse the repository at this point in the history

  6. max

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    13be4e4 View commit details
    Browse the repository at this point in the history

  7. add test

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    1c722de View commit details
    Browse the repository at this point in the history

  8. Merge branch 'PyTorchLightning:master' into audio-pit

    @quancs
    quancs authored Jul 17, 2021
    Configuration menu
    Copy the full SHA
    9a538eb View commit details
    Browse the repository at this point in the history

  9. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    123a686 View commit details
    Browse the repository at this point in the history

  10. add

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    5d2977c View commit details
    Browse the repository at this point in the history

  11. fix pep8

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    3b9172f View commit details
    Browse the repository at this point in the history

  12. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    2c01d18 View commit details
    Browse the repository at this point in the history

  13. fix pep8

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    7c2078f View commit details
    Browse the repository at this point in the history

  14. Merge branch 'audio-pit' of https://github.com/quancs/metrics into au… 

    …dio-pit
    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    70d964e View commit details
    Browse the repository at this point in the history

  15. fix mypy

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    85daf5c View commit details
    Browse the repository at this point in the history

  16. add scipy

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    e129896 View commit details
    Browse the repository at this point in the history

  17. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    bcf43a3 View commit details
    Browse the repository at this point in the history

  18. fix

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    801b80c View commit details
    Browse the repository at this point in the history

  19. Merge branch 'audio-pit' of https://github.com/quancs/metrics into au… 

    …dio-pit
    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    afaa79c View commit details
    Browse the repository at this point in the history

  20. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    f9f770f View commit details
    Browse the repository at this point in the history

  21. fix doctest

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    dee14ea View commit details
    Browse the repository at this point in the history

  22. Merge branch 'audio-pit' of https://github.com/quancs/metrics into au… 

    …dio-pit
    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    5d06bf1 View commit details
    Browse the repository at this point in the history

  23. fix doctest

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    de37c92 View commit details
    Browse the repository at this point in the history

  24. fix doctest

    @quancs
    quancs committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    05e061b View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. remove scipy dep & add warning

    @quancs
    quancs committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    ae12aa0 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    112bc16 View commit details
    Browse the repository at this point in the history

  3. change warn

    @quancs
    quancs committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    dc5e689 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'audio-pit' of https://github.com/quancs/metrics into au… 

    …dio-pit
    @quancs
    quancs committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    6a3beda View commit details
    Browse the repository at this point in the history

  5. add

    @quancs
    quancs committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    208b479 View commit details
    Browse the repository at this point in the history

  6. move scipy import to inner function

    @quancs
    quancs committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    736e354 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Merge branch 'master' into audio-pit

    @Borda
    Borda authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    a7a4588 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @Borda
    Borda authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    271d899 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    2e1ae3f View commit details
    Browse the repository at this point in the history

  4. simplyfied

    @quancs
    quancs committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1059575 View commit details
    Browse the repository at this point in the history

  5. add test_consistency_of_two_implementations

    @quancs
    quancs committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    07ecb26 View commit details
    Browse the repository at this point in the history

  6. use _SCIPY_AVAILABLE

    @quancs
    quancs committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    16d70f9 View commit details
    Browse the repository at this point in the history

  7. add docstring

    @quancs
    quancs committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b452792 View commit details
    Browse the repository at this point in the history

  8. to TIME

    @quancs
    quancs committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    6367adc View commit details
    Browse the repository at this point in the history

  9. a_naive_implementation_of_pit_based_on_scipy

    @quancs
    quancs committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    29744ab View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    2070d3a View commit details
    Browse the repository at this point in the history

  11. add docstring for _find_best_perm_by_linear_sum_assignment

    @quancs
    quancs committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    859e25e View commit details
    Browse the repository at this point in the history

  12. Merge branch 'audio-pit' of https://github.com/quancs/metrics into au… 

    …dio-pit
    @quancs
    quancs committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    776cf88 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Update torchmetrics/functional/audio/pit.py 

    Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
    @quancs @SkafteNicki
    quancs and SkafteNicki authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    70adaa3 View commit details
    Browse the repository at this point in the history

  2. Update torchmetrics/functional/audio/pit.py 

    Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
    @quancs @SkafteNicki
    quancs and SkafteNicki authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    a17b357 View commit details
    Browse the repository at this point in the history

  3. Update torchmetrics/functional/audio/pit.py 

    Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
    @quancs @SkafteNicki
    quancs and SkafteNicki authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    39105ae View commit details
    Browse the repository at this point in the history

  4. Update torchmetrics/functional/audio/pit.py 

    Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
    @quancs @SkafteNicki
    quancs and SkafteNicki authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    dbb0e5a View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    c308c02 View commit details
    Browse the repository at this point in the history

  6. use self.run_functional_metric_test

    @quancs
    quancs committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    a4e347a View commit details
    Browse the repository at this point in the history

  7. add more description

    @quancs
    quancs committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    01d484e View commit details
    Browse the repository at this point in the history

  8. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    5a974e9 View commit details
    Browse the repository at this point in the history

  9. import warnings

    @quancs
    quancs committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    400b323 View commit details
    Browse the repository at this point in the history

  10. check ValueError

    @quancs
    quancs committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    458b912 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'audio-pit' of https://github.com/quancs/metrics into au… 

    …dio-pit
    @quancs
    quancs committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    041dfaf View commit details
    Browse the repository at this point in the history

  12. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    5d709d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Merge branch 'master' into audio-pit

    @Borda
    Borda authored Jul 24, 2021
    Configuration menu
    Copy the full SHA
    9d15f89 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Merge branch 'master' into audio-pit

    @Borda
    Borda authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    30e7f67 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Merge branch 'master' into audio-pit

    @Borda
    Borda authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    312999a View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8d3ed75 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
    @Borda @SkafteNicki
    Borda and SkafteNicki authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    ca3425d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into audio-pit

    @SkafteNicki
    SkafteNicki authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    36911fd View commit details
    Browse the repository at this point in the history

  5. fix imports

    @Borda
    Borda committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    1bd7f5d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into audio-pit

    @Borda
    Borda authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6b143c7 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    05cacbb View commit details
    Browse the repository at this point in the history

  8. fix test

    @Borda
    Borda committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    9db192f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'audio-pit' of https://github.com/quancs/metrics into au… 

    …dio-pit
    @Borda
    Borda committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    bf41ab6 View commit details
    Browse the repository at this point in the history

  10. docs

    @Borda
    Borda committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    65a27ff View commit details
    Browse the repository at this point in the history

  11. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a63297d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Merge branch 'master' into audio-pit

    @Borda
    Borda authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    6177f78 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: thomas chaton <thomas@grid.ai>
    @Borda @tchaton
    Borda and tchaton authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    8f3dc55 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @SkafteNicki
    SkafteNicki authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    23ab576 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    72eace5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into audio-pit

    @Borda
    Borda authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    30c94e6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into audio-pit

    @Borda
    Borda authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    40b7e81 View commit details
    Browse the repository at this point in the history