-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dtype issues #493
Fix dtype issues #493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=======================================
- Coverage 95% 72% -23%
=======================================
Files 132 132
Lines 4681 4676 -5
=======================================
- Hits 4462 3365 -1097
- Misses 219 1311 +1092 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@ethanwharris mind have look? ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, confirmed that this fixes my issue 😃 thanks @SkafteNicki !
@SkafteNicki seems some tests are running for too long with latest versions |
Before submitting
What does this PR do?
Fixes #492
Fixes #484
Reverts some of the changes in #462.
dtype
property. Metrics state can have different dtypes (like any othernn.Module
) so the property probably does not make sense for all metricshalf
,float
,double
will now have no effect on the dtype of metric states to prevent that metrics gets auto-cast during mix-precision. Instead if the user really wants to change the dtype of all metric states they can now do it using theset_dtype
method.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃