Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP metric - fix empty predictions #594

Merged
merged 8 commits into from
Oct 29, 2021
Merged

MAP metric - fix empty predictions #594

merged 8 commits into from
Oct 29, 2021

Conversation

tkupek
Copy link
Contributor

@tkupek tkupek commented Oct 29, 2021

What does this PR do?

This PR fixes a bug in the MAP detection metric, which crashes if the predictions are an empty list.
I added a test for this case and fixes the issue in the metric.

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #594 (7028c4b) into master (e44b51b) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #594   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         150    150           
  Lines        5308   5308           
=====================================
- Hits         5050   5048    -2     
- Misses        258    260    +2     

@Borda Borda added the bug / fix Something isn't working label Oct 29, 2021
tests/detection/test_map.py Outdated Show resolved Hide resolved
tests/detection/test_map.py Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) October 29, 2021 09:34
@Borda Borda merged commit 1c42f66 into Lightning-AI:master Oct 29, 2021
@mergify mergify bot added the ready label Oct 29, 2021
@tkupek tkupek mentioned this pull request Nov 8, 2021
4 tasks
@tkupek tkupek deleted the map-fix-empty-preds branch November 15, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants