Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weighted AUROC on gpu #606

Merged
merged 5 commits into from
Nov 8, 2021
Merged

Fix weighted AUROC on gpu #606

merged 5 commits into from
Nov 8, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 4, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #602
Fixes an edge case of AUROC. We already had solved it on cpu but forgot to check if it was the case on gpu. This PR adds support on gpu.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Nov 4, 2021
@SkafteNicki SkafteNicki added this to the v0.7 milestone Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #606 (9b3af99) into master (7161bb6) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #606   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         150    150           
  Lines        5308   5308           
=====================================
- Hits         5050   5048    -2     
- Misses        258    260    +2     

@Borda Borda modified the milestones: v0.7, v0.6 Nov 4, 2021
@Borda
Copy link
Member

Borda commented Nov 4, 2021

@SkafteNicki just add chlog entry :]

@mergify mergify bot added the ready label Nov 4, 2021
@Borda Borda enabled auto-merge (squash) November 8, 2021 14:35
@Borda Borda merged commit c519402 into master Nov 8, 2021
@Borda Borda deleted the fix_auroc branch November 8, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false device inconsistent runtime error
3 participants