-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove the requirement for double update in forward #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
tchaton
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren and
SkafteNicki
as code owners
November 9, 2021 16:07
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
=======================================
- Coverage 95% 70% -25%
=======================================
Files 166 166
Lines 6795 6813 +18
=======================================
- Hits 6469 4795 -1674
- Misses 326 2018 +1692 |
tchaton
changed the title
Remove the requirement for double update in forward
[WIP] Remove the requirement for double update in forward
Nov 9, 2021
@tchaton any update here? 🐰 |
@tchaton any update here? 🐰 |
Borda
force-pushed
the
master
branch
3 times, most recently
from
January 10, 2022 13:05
3a0f7dc
to
317182c
Compare
SkafteNicki
reviewed
Feb 8, 2022
for more information, see https://pre-commit.ci
@SkafteNicki, are we going to proceed with this one? 🐰 |
4 tasks
Closing in favour of #984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
This PR optimizer the forward method of the Metric base class to prevent performing 2 updates.
Parts of #344
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃