Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: set HF caching #691

Merged
merged 2 commits into from
Dec 22, 2021
Merged

CI: set HF caching #691

merged 2 commits into from
Dec 22, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 21, 2021

What does this PR do?

Try to cache HF transformer models/tokenizors

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added enhancement New feature or request test / CI testing or CI labels Dec 21, 2021
@mergify mergify bot requested a review from a team December 21, 2021 20:35
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #691 (e83ede2) into master (67f78ab) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #691   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         166    166           
  Lines        6413   6413           
=====================================
  Hits         6105   6105           
  Misses        308    308           

.github/workflows/ci_test-base.yml Outdated Show resolved Hide resolved
.github/workflows/ci_test-conda.yml Outdated Show resolved Hide resolved
.github/workflows/ci_test-full.yml Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team December 21, 2021 20:45
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
@mergify mergify bot added the ready label Dec 22, 2021
@Borda Borda disabled auto-merge December 22, 2021 10:15
@Borda Borda merged commit 63d0d75 into master Dec 22, 2021
@Borda Borda deleted the ci/hf-cache branch December 22, 2021 10:15
Borda added a commit that referenced this pull request Dec 22, 2021
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
SkafteNicki added a commit that referenced this pull request Jan 10, 2022
* [WIP] Add MS-SSIM

* Fix docs and a mypy issue

* fix badge

* Apply some SkafteNicki's suggestions from code review

* Fix docstring: MS_SSIM -> MultiScaleSSIM

* Fix missed MS_SSIM in a docstring

* flake8

* Add tests

* Update doc example

* Fix seed for doc + update some tests

* Clean code

* Update doc example + make diff test tractable

* torch.manual seed passed directly to torch.rand

* Apply suggestions from code review

* Drop some tests ; fix docs issues + add missing docs

* Update paper.md (#690)

* ci: rename oldest

* CI: set HF caching (#691)

* Apply suggestions: ms_ssim -> multiscale_ssim + typing

* Update doc reference

* Apply SkafteNicki's suggestions

* Update test reference package

* Clean test

* Change naming multiscale_ssim -> multiscale_structual_similarity_index_measure

* Update docs references

* Fix a typo: structual -> structural

* fix one last typo

* Fix ~ len in a doc

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Maxim Grechkin <maximsch2@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants