-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: SNR & SI_SNR #712
Conversation
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
=====================================
Coverage 73% 73%
=====================================
Files 166 166
Lines 6465 6483 +18
=====================================
+ Hits 4730 4748 +18
Misses 1735 1735 |
The SNR is often called signal to noise ratio. And SDR is offen called signal to distortion ratio |
367fd59
to
a2941cc
Compare
@PyTorchLightning/core-metrics updated and keeping abbreviations, pls check it now 🐰 |
I would go with 1 |
for more information, see https://pre-commit.ci
* signal_noise_ratio * scale_invariant_signal_noise_ratio * SignalNoiseRatio * ScaleInvariantSignalNoiseRatio Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* signal_noise_ratio * scale_invariant_signal_noise_ratio * SignalNoiseRatio * ScaleInvariantSignalNoiseRatio Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What does this PR do?
Unify the notation and keep more descriptive functional names
part of #729
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃