Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify f1 score #731

Merged
merged 16 commits into from
Jan 9, 2022
Merged

unify f1 score #731

merged 16 commits into from
Jan 9, 2022

Conversation

cuent
Copy link
Contributor

@cuent cuent commented Jan 8, 2022

What does this PR do?

Refactor F1 score

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@cuent
Copy link
Contributor Author

cuent commented Jan 8, 2022

Should F1 object be renamed to F1Score?

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #731 (907c4ed) into master (459b01e) will decrease coverage by 22%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #731     +/-   ##
=======================================
- Coverage      95%    73%    -22%     
=======================================
  Files         166    166             
  Lines        6483   6494     +11     
=======================================
- Hits         6174   4759   -1415     
- Misses        309   1735   +1426     

@stancld
Copy link
Contributor

stancld commented Jan 8, 2022

Should F1 object be renamed to F1Score?

Yes, please use F1Score for the class name :]

@Borda Borda mentioned this pull request Jan 8, 2022
12 tasks
@Borda Borda added API / design refactoring refactoring and code health labels Jan 8, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • deprecation warnings & back compatibility
  • rename also F1 class to be consistent (suggestion F1Score)
  • add changelog

part of #729

@Borda Borda added this to the v0.7 milestone Jan 8, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecation warnings & back-compatibility, see #731 (review)

@cuent cuent requested review from Borda and stancld January 9, 2022 02:58
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Jan 9, 2022
docs/source/references/modules.rst Outdated Show resolved Hide resolved
@Borda Borda merged commit c20860a into Lightning-AI:master Jan 9, 2022
Borda added a commit to AIMistakes/metrics that referenced this pull request Jan 10, 2022
* f1_score
* F1Score

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / design ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants