CI: dynamic testing #764
Merged
CI: dynamic testing #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 171 171
Lines 6926 6926
=====================================
Hits 4917 4917
Misses 2009 2009 |
Borda
force-pushed
the
ci/dynamic-testing
branch
2 times, most recently
from
9c1d7ba to
613800e
Compare
Borda
requested review from
ananyahjha93,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
Borda
force-pushed
the
ci/dynamic-testing
branch
from
dd73afc to
19032b8
Compare
Borda
force-pushed
the
ci/dynamic-testing
branch
from
19032b8 to
8c2767c
Compare
Borda
force-pushed
the
ci/dynamic-testing
branch
from
f6ff8f1 to
38033a0
Compare
Borda
commented
Jan 17, 2022
|
Should we have some tests that the assistant is doing what it is supposed to do? |
SkafteNicki
approved these changes
Jan 18, 2022
justusschock
approved these changes
Jan 18, 2022
|
seems to be working as expected... run just text-domain for this related deprecation pruning |
|
or the similar just fro improving one classification metric: |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses #678 (comment)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃