Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version incompatibility with pytest and pytest-doctestplus #827

Merged
merged 3 commits into from
Feb 5, 2022

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Feb 4, 2022

What does this PR do?

Pytest == 7.0 with doctest-plus causes erros in Python 3.6.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #827 (37a1dd7) into master (ac6539b) will decrease coverage by 24%.
The diff coverage is n/a.

❗ Current head 37a1dd7 differs from pull request most recent head 6e885a3. Consider uploading reports for the commit 6e885a3 to get more accurate results

@@           Coverage Diff           @@
##           master   #827     +/-   ##
=======================================
- Coverage      95%    71%    -24%     
=======================================
  Files         166    166             
  Lines        6832   6832             
=======================================
- Hits         6457   4817   -1640     
- Misses        375   2015   +1640     

@ethanwharris ethanwharris marked this pull request as ready for review February 4, 2022 20:05
@ethanwharris ethanwharris added the test / CI testing or CI label Feb 4, 2022
requirements/test.txt Show resolved Hide resolved
@Borda Borda requested a review from carmocca February 4, 2022 23:49
@Borda Borda enabled auto-merge (squash) February 4, 2022 23:51
@Borda Borda self-assigned this Feb 4, 2022
@Borda Borda disabled auto-merge February 5, 2022 00:15
@Borda Borda merged commit 385b18e into master Feb 5, 2022
@Borda Borda deleted the bugfix/pytest_version branch February 5, 2022 00:15
Borda pushed a commit that referenced this pull request Feb 5, 2022
* Set min. doctest-plus version
* Pin pytest version

(cherry picked from commit 385b18e)
@mergify mergify bot added the ready label Feb 5, 2022
@Borda Borda added this to the v0.8 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants