Add new metrics: SAM
#885
Merged
Add new metrics: SAM
#885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vumichien
requested review from
Borda,
SkafteNicki,
justusschock,
ananyahjha93,
tchaton,
ethanwharris and
SeanNaren
as code owners
for more information, see https://pre-commit.ci
# Conflicts: # torchmetrics/__init__.py # torchmetrics/image/sam.py
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
=======================================
- Coverage 95% 71% -24%
=======================================
Files 169 171 +2
Lines 7096 7149 +53
=======================================
- Hits 6748 5086 -1662
- Misses 348 2063 +1715 |
stancld
reviewed
Mar 11, 2022
There was a problem hiding this comment.
Hi @vumichien, can you please also update CHANGELOG.md and add this new metric into the docs (docs/source/references/{functional,modules}.rst files.):
|
@stancld Sorry I forgot it. I just updated them |
Paul-Aime
reviewed
Mar 12, 2022
Paul-Aime
reviewed
Mar 12, 2022
Paul-Aime
suggested changes
Mar 12, 2022
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Paul-Aime
reviewed
Mar 21, 2022
|
@Borda @SkafteNicki Could you help me to resolve this conflict with master? |
# Conflicts: # CHANGELOG.md
SkafteNicki
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new Metric SAM #799
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃