Refactor: allow reduction None #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
SkafteNicki,
justusschock,
ananyahjha93,
tchaton,
ethanwharris and
SeanNaren
as code owners
for more information, see https://pre-commit.ci
…ing/metrics into refactor/reduction
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 167 167
Lines 6933 6947 +14
=====================================
+ Hits 6589 6603 +14
Misses 344 344 |
akihironitta
approved these changes
Mar 18, 2022
it is the same, just had a feeling that less bracket depth makes it easier to read :) |
4 tasks
justusschock
approved these changes
Mar 18, 2022
gianscarpe
pushed a commit
to gianscarpe/metrics
that referenced
this pull request
Apr 21, 2022
* allow reduction None * Literal Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Just to be consistent with other reduction options
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃