Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new image metric - ERGAS #894

Merged
merged 24 commits into from
Mar 22, 2022
Merged

Conversation

vumichien
Copy link
Contributor

What does this PR do?

Adds new Metric ERGAS #799

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda mentioned this pull request Mar 18, 2022
@vumichien vumichien changed the title Added new image metric - ERGAS Adds new image metric - ERGAS Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #894 (9f09f12) into master (3653838) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #894   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         171    173    +2     
  Lines        7181   7237   +56     
=====================================
+ Hits         6830   6857   +27     
- Misses        351    380   +29     

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]

docs/source/references/functional.rst Outdated Show resolved Hide resolved
tests/image/test_ergas.py Outdated Show resolved Hide resolved
torchmetrics/image/ergas.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Mar 21, 2022
@mergify mergify bot removed the has conflicts label Mar 21, 2022
tests/helpers/reference_metrics.py Outdated Show resolved Hide resolved
tests/helpers/reference_metrics.py Outdated Show resolved Hide resolved
torchmetrics/functional/image/ergas.py Outdated Show resolved Hide resolved
tests/helpers/reference_metrics.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the ready label Mar 21, 2022
@Borda
Copy link
Member

Borda commented Mar 21, 2022

@vumichien mind check the:

E       b, c, h, w = preds.shape
E       ^
E   IndentationError: unexpected indent

@mergify mergify bot added the ready label Mar 21, 2022
@vumichien
Copy link
Contributor Author

@SkafteNicki Thanks for helping me a lot

tests/image/test_ergas.py Outdated Show resolved Hide resolved
torchmetrics/image/ergas.py Outdated Show resolved Hide resolved
torchmetrics/image/ergas.py Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) March 22, 2022 08:56
@Borda Borda disabled auto-merge March 22, 2022 08:56
@Borda Borda enabled auto-merge (squash) March 22, 2022 08:56
@Borda Borda added this to the v0.8 milestone Mar 22, 2022
@mergify mergify bot removed the ready label Mar 22, 2022
@Borda Borda merged commit 9606515 into Lightning-AI:master Mar 22, 2022
@mergify mergify bot added the ready label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants