Fix torch.bincount when running in deterministic mode and on GPU #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
SkafteNicki
commented
Mar 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
======================================
- Coverage 95% 91% -5%
======================================
Files 173 173
Lines 7241 7253 +12
======================================
- Hits 6890 6571 -319
- Misses 351 682 +331 |
SkafteNicki
changed the title
SkafteNicki
commented
Mar 22, 2022
…thub.com/PyTorchLightning/metrics into bugfix/deterministic_gpu_confusionmatrix
justusschock
approved these changes
Mar 22, 2022
Borda
reviewed
Mar 22, 2022
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
for more information, see https://pre-commit.ci
Borda
approved these changes
Mar 22, 2022
|
@SkafteNicki seems that ERGAS is now failing on Windows with the latest configurations :/ UPDATE: it is unrelated, and fixing it in a6621cb |
Borda
pushed a commit
that referenced
this pull request
Mar 23, 2022
* update all torch bincounts * move test * Apply suggestions from code review Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 0240d33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #880
Implement an alternative of
torch.bincountwhen the user is running in deterministic mode and on GPU.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃