re-implement the signal_distortion_ratio metric
#964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 177 177
Lines 7509 7513 +4
=====================================
- Hits 7135 7126 -9
- Misses 374 387 +13 |
quancs
changed the title
signal_distortion_ratio metricsignal_distortion_ratio metric
for more information, see https://pre-commit.ci
|
@quancs this is great! 💜 |
quancs
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
Removed |
SkafteNicki
approved these changes
Apr 20, 2022
Borda
reviewed
Apr 20, 2022
Borda
reviewed
Apr 20, 2022
quancs
commented
Apr 20, 2022
|
maybe we still need to patch some PT versions: |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
pushed a commit
that referenced
this pull request
Apr 26, 2022
* reimplement signal_distortion_ratio * sdr is differentiable for all supported pytorch version now * update & fix * chlog * Apply suggestions from code review Co-authored-by: quancs <quancs@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> (cherry picked from commit f8ef656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #803
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃