Minor Finetuning Scheduler Tutorial Update #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speediedan
requested review from
Borda,
ethanwharris,
rohitgr7,
carmocca,
kaushikb11 and
SeanNaren
as code owners
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
===================================
Coverage 75% 75%
===================================
Files 2 2
Lines 370 370
===================================
Hits 276 276
Misses 94 94 |
references on nbval job, add reference to new fts release param
speediedan
force-pushed
the
fts_tutorial_update
branch
from
099f8ac
to
ff60373
Compare
This was referenced Jun 11, 2022
Merged
Closed
speediedan
force-pushed
the
fts_tutorial_update
branch
from
90a218d
to
7813019
Compare
…ease due to bug in omegaconf 2.0.6 that requires omegaconfig >=2.1.0 which in turns requires hydra-core>=1.1.0 if it's installed (fts does not require hydra)
speediedan
force-pushed
the
fts_tutorial_update
branch
from
7813019
to
a269bbb
Compare
rohitgr7
approved these changes
Jun 13, 2022
lightning_examples/finetuning-scheduler/finetuning-scheduler.py
Outdated
Show resolved
Hide resolved
Borda
approved these changes
Jun 13, 2022
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Minor fix for stale finetuning scheduler link, fix for finetuning scheduler tutorial tag capitalization and minor tutorial update referencing additional extension features.
Note that this PR should be merged in addition to the minor css enhancement PR to allow the submodule update PR to succeed.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃