Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bash loading last line from file #269

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix bash loading last line from file #269

merged 3 commits into from
Sep 11, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 9, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

turned out that last lines were skipped, see https://stackoverflow.com/a/12919766

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug / fix Something isn't working label Sep 9, 2023
@Borda Borda requested a review from ethanwharris as a code owner September 9, 2023 00:51
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #269 (1a180e3) into main (098d010) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #269   +/-   ##
===================================
  Coverage    73%    73%           
===================================
  Files         2      2           
  Lines       382    382           
===================================
  Hits        280    280           
  Misses      102    102           

.github/workflows/ci_docs.yml Show resolved Hide resolved
.github/workflows/ci_docs.yml Show resolved Hide resolved
.azure/ipynb-publish.yml Show resolved Hide resolved
@Borda Borda changed the title fix bash loading last ine from file fix bash loading last line from file Sep 11, 2023
@Borda Borda merged commit b79ba09 into main Sep 11, 2023
15 checks passed
@Borda Borda deleted the fix/last-line branch September 11, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant