Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup basic package functionality with CLI #3

Merged
merged 14 commits into from
Jul 15, 2022
Merged

setup basic package functionality with CLI #3

merged 14 commits into from
Jul 15, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 14, 2022 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda marked this pull request as ready for review July 14, 2022 19:37
@Borda Borda requested a review from akihironitta as a code owner July 14, 2022 19:37
@Borda Borda added the enhancement New feature or request label Jul 14, 2022
akihironitta
akihironitta approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

.github/workflows/ci_testing.yml Show resolved Hide resolved
src/pl_devtools/dependencies.py Outdated Show resolved Hide resolved
Borda
Borda commented Jul 15, 2022
View reviewed changes
src/pl_devtools/__main__.py Outdated Show resolved Hide resolved
Borda
Borda commented Jul 15, 2022
View reviewed changes
src/pl_devtools/__main__.py Outdated Show resolved Hide resolved
@Borda Borda merged commit cff7f59 into main Jul 15, 2022
@Borda Borda deleted the pkg/main branch July 15, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @akihironitta