Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: abstract package actions #48

Merged
merged 11 commits into from
Dec 24, 2022
Merged

CI: abstract package actions #48

merged 11 commits into from
Dec 24, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 12, 2022 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

try to generalize the package check and installation

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Sep 12, 2022
@Borda Borda self-assigned this Sep 12, 2022
@Borda
Copy link
Member Author

Borda commented Dec 19, 2022

consider using tolerant download if the initial/empty artifact is missing: https://github.com/dawidd6/action-download-artifact

@Borda
Copy link
Member Author

Borda commented Dec 24, 2022

will be finished after #51

@Borda Borda marked this pull request as ready for review December 24, 2022 07:33
akihironitta
akihironitta approved these changes Dec 24, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

.github/actions/pkg-create/action.yml Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) December 24, 2022 14:29
@Borda Borda merged commit 7bf0a35 into main Dec 24, 2022
@Borda Borda deleted the ci/pkg-actions branch December 24, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

Assignees

@Borda Borda

Labels
enhancement New feature or request
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @akihironitta