Apply suggestions from code review

Lightning-Universe · Aug 5, 2021 · 82d080e · 82d080e
1 parent f531595
commit 82d080e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pl_bolts/models/rl/dqn_model.py b/pl_bolts/models/rl/dqn_model.py
@@ -404,7 +404,8 @@ def add_model_specific_args(arg_parser: argparse.ArgumentParser, ) -> argparse.A
 
  return arg_parser
 
- def _use_dp_or_ddp2(self, trainer: Trainer) -> bool:
+ @staticmethod
+ def _use_dp_or_ddp2(trainer: Trainer) -> bool:
  # for backwards compatibility
  if _PL_GREATER_EQUAL_1_4:
  return trainer.accelerator_connector.use_dp or trainer.accelerator_connector.use_ddp2

diff --git a/pl_bolts/models/self_supervised/moco/moco2_module.py b/pl_bolts/models/self_supervised/moco/moco2_module.py
@@ -335,7 +335,8 @@ def add_model_specific_args(parent_parser):
 
  return parser
 
- def _use_ddp_or_ddp2(self, trainer: Trainer) -> bool:
+ @staticmethod
+ def _use_ddp_or_ddp2(trainer: Trainer) -> bool:
  # for backwards compatibility
  if _PL_GREATER_EQUAL_1_4:
  return trainer.accelerator_connector.use_ddp or trainer.accelerator_connector.use_ddp2