Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple DataModules from Models #207

Closed
nateraw opened this issue Sep 11, 2020 · 3 comments · Fixed by #332
Closed

Decouple DataModules from Models #207

nateraw opened this issue Sep 11, 2020 · 3 comments · Fixed by #332
Assignees
Labels
datamodule Anything related to datamodules enhancement New feature or request help wanted Extra attention is needed won't fix This will not be worked on

Comments

@nateraw
Copy link
Contributor

nateraw commented Sep 11, 2020

🚀 Feature

Most of the models have 'datamodule' as an init arg and/or implement a 'default datamodule' and set that as a class attribute if datamodule is not passed on init.

This causes problems...

  • it explicitly bakes in dataset specific stuff in the model (which kinda defeats the purpose of the datamodule)
  • it forces the user to use a datamodule (not cool, dude!)

So, we need to go through each model and decouple the hard-coded datamodules to get rid of these issues.

Motivation

Pitch

Alternatives

Additional context

@nateraw nateraw added enhancement New feature or request help wanted Extra attention is needed labels Sep 11, 2020
This was referenced Sep 11, 2020
@nateraw nateraw self-assigned this Sep 11, 2020
@nateraw nateraw added the datamodule Anything related to datamodules label Sep 11, 2020
@Borda Borda closed this as completed in #332 Nov 9, 2020
@akihironitta
Copy link
Contributor

akihironitta commented Nov 15, 2020

We still have things to do here, so could you keep this issue open?

As far as I could find, we need to decouple datamodules from the following models:

@stale
Copy link

stale bot commented Jan 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jan 30, 2021
@akihironitta akihironitta removed the won't fix This will not be worked on label Jan 31, 2021
@stale
Copy link

stale bot commented Apr 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 2, 2021
@stale stale bot closed this as completed Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules enhancement New feature or request help wanted Extra attention is needed won't fix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants