Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Main #208

Open
nateraw opened this issue Sep 11, 2020 · 0 comments
Open

Generic Main #208

nateraw opened this issue Sep 11, 2020 · 0 comments
Labels
discussion enhancement New feature or request help wanted Extra attention is needed

Comments

@nateraw
Copy link
Contributor

nateraw commented Sep 11, 2020

🚀 Feature

Once DMs have been decoupled from models (#207) + we have map of aliases-to-classes (#201), we can put together a generic_main function that'll work for 90% of the models in this repo.

Motivation

  • Makes running experiments really easy
  • Allows us to parameterize tests super elegantly (1 test function to rule them all that is parameterized w/ pytest).

Pitch

something along the lines of this from the command line...

pl_bolts run --model vae --datamodule mnist --...any dm or model flag...

or this from python

from pl_bolts import bolts_main

bolts_main(model='vae', datamodule='mnist', **kwargs)

Alternatives

Additional context

Its significantly more complex to do this generically within lightning itself, but since we have control over interface of dms in this repo, we can cut a few corners to make it happen here for now while we work out the kinks for a generic main in lightning.

@nateraw nateraw added enhancement New feature or request help wanted Extra attention is needed labels Sep 11, 2020
@nateraw nateraw self-assigned this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants