Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test importing when optional packages are unavailable #421

Closed
akihironitta opened this issue Dec 2, 2020 · 0 comments · Fixed by #428
Closed

Test importing when optional packages are unavailable #421

akihironitta opened this issue Dec 2, 2020 · 0 comments · Fixed by #428
Assignees
@akihironitta
Labels
ci/cd Continues Integration and delivery enhancement New feature or request
Milestone
v0.4

Comments

@akihironitta
Copy link
Contributor

🚀 Feature

I have added the tests for importing datamodules when optional packages, such as torchvision and sklearn, are unavailable in #380, and we should do the same for other submodules.

Motivation

Importing datamodules/models fail without optional packages very often as reported in:

Alternatives

Additional context
@akihironitta akihironitta added enhancement New feature or request ci/cd Continues Integration and delivery labels Dec 2, 2020
@akihironitta akihironitta self-assigned this Dec 2, 2020
@akihironitta akihironitta changed the title Add tests for imports when optional packages are unavailable Test importing when optional packages are unavailable Dec 7, 2020
@akihironitta akihironitta mentioned this issue Dec 7, 2020
Merged
8 tasks
@akihironitta akihironitta mentioned this issue Jan 17, 2021
Closed
9 tasks
@Borda Borda modified the milestones: v0.3, v0.4 Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akihironitta akihironitta

Labels
ci/cd Continues Integration and delivery enhancement New feature or request
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Add tests for imports when optional packages are unavailable akihironitta/lightning-bolts
2 participants
@Borda @akihironitta