-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for imports when optional packages are unavailable #428
Conversation
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
===========================================
- Coverage 72.01% 24.83% -47.18%
===========================================
Files 119 119
Lines 7367 7332 -35
===========================================
- Hits 5305 1821 -3484
- Misses 2062 5511 +3449
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hello @akihironitta! Thanks for updating this PR.
Comment last updated at 2021-06-24 02:35:00 UTC |
@akihironitta what is missing to finish it, mind update the description with linking the partial PRs? |
I completely forgot about this PR. I'll quickly make this PR ready for review!
Actually, all tests for optional imports are being added in this PR because I thought it's quite easy to review at once... I'll split this PR into several PRs if you'd like :] |
can you pls make it the only change of this PR? |
for more information, see https://pre-commit.ci
@Borda Could you have another look? |
What does this PR do?
Fixes #421.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃