-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly incorrect documentation for VAE #543
Labels
Comments
Hi! thanks for your contribution!, great first issue! |
akihironitta
added
model
documentation
Improvements or additions to documentation
labels
Jan 29, 2021
@jeremyadamsfisher Hi, thank you for reporting the issue! Following the suggestion by @ananyahjha93 in #200 (comment), let's just fix the docs for now.
|
@jeremyadamsfisher Would you be interested in submitting a PR? |
8 tasks
Yeah, no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The example for a VAE indicates that
from_pretrained
is a static methodhttps://github.com/PyTorchLightning/pytorch-lightning-bolts/blob/4e1c1502b70e4be59a9ac80878ec5ad5a212f87e/pl_bolts/models/autoencoders/basic_vae/basic_vae_module.py#L30
Indeed, running this line causes as error:
This is because the method is actually implemented nonstatically:
Seems to me either:
vae = VAE(32).from_pretrained(...)
)Here is a minimal failing example on colab: https://colab.research.google.com/drive/1quvrQUyCIMC7Cq9QCjaJfip5hsi9jwSJ?usp=sharing
Happy to write a PR, if desired
The text was updated successfully, but these errors were encountered: