-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AE and VAE documentation #557
Update AE and VAE documentation #557
Conversation
Previously, pretrained models were initialized with a static method. Now, they are initialized with an instance method. Upates docstring accordingly.
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
===========================================
- Coverage 77.58% 26.23% -51.36%
===========================================
Files 115 115
Lines 6701 6675 -26
===========================================
- Hits 5199 1751 -3448
- Misses 1502 4924 +3422
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremyadamsfisher Thank you for your contribution! LGTM!
Done. Other parts of the code don't have this issue because they don't have the API suggested in issue #200 . Here's where I've looked
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremyadamsfisher Thank you for your swift action!
What does this PR do?
Previously, pretrained models were initialized with a static method. Now, they are initialized with an instance method. Upate docstring accordingly.
Fixes #543
Before submitting
On the master and on this branch, I have the following test failures:
They seem unrelated to this issue
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
🚀🚀🚀