Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test for City data creation #343

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix test for City data creation #343

merged 1 commit into from
Nov 6, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 6, 2020

What does this PR do?

Fixes #315
Turned out that with the existing cache City datasets is failing

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added fix fixing issues... ci/cd Continues Integration and delivery labels Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #343 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   82.32%   82.42%   +0.09%     
==========================================
  Files         100      100              
  Lines        5602     5621      +19     
==========================================
+ Hits         4612     4633      +21     
+ Misses        990      988       -2     
Flag Coverage Δ
cpu 24.75% <ø> (ø)
pytest 24.75% <ø> (ø)
unittests 81.67% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/utils/arguments.py 96.15% <0.00%> (+0.04%) ⬆️
.../models/autoencoders/basic_vae/basic_vae_module.py 91.66% <0.00%> (+0.08%) ⬆️
pl_bolts/losses/self_supervised_learning.py 77.70% <0.00%> (+0.14%) ⬆️
...ts/models/autoencoders/basic_ae/basic_ae_module.py 88.00% <0.00%> (+0.16%) ⬆️
pl_bolts/models/rl/common/gym_wrappers.py 89.91% <0.00%> (+0.26%) ⬆️
pl_bolts/datasets/imagenet_dataset.py 18.45% <0.00%> (+0.38%) ⬆️
pl_bolts/optimizers/lars_scheduling.py 95.74% <0.00%> (+0.39%) ⬆️
..._bolts/models/self_supervised/moco/moco2_module.py 79.23% <0.00%> (+0.49%) ⬆️
pl_bolts/datasets/ssl_amdim_datasets.py 75.00% <0.00%> (+1.08%) ⬆️
...l_bolts/models/rl/vanilla_policy_gradient_model.py 94.64% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00e85d...ea1c439. Read the comment docs.

@Borda Borda changed the title fix City data creation fix test for City data creation Nov 6, 2020
@Borda Borda merged commit 4d254fd into master Nov 6, 2020
@Borda Borda deleted the tests/data-city branch November 6, 2020 16:04
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery fix fixing issues...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant