Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to type Any for batch argument #495

Merged
merged 1 commit into from
Jan 4, 2021
Merged

change to type Any for batch argument #495

merged 1 commit into from
Jan 4, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Jan 4, 2021

What does this PR do?

Fixes # #444 (review)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #495 (f1d7cc5) into master (ce3187d) will decrease coverage by 53.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #495       +/-   ##
===========================================
- Coverage   79.10%   25.57%   -53.54%     
===========================================
  Files         102      102               
  Lines        5921     5900       -21     
===========================================
- Hits         4684     1509     -3175     
- Misses       1237     4391     +3154     
Flag Coverage Δ
cpu 25.57% <100.00%> (ø)
pytest 25.57% <100.00%> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/callbacks/data_monitor.py 40.70% <100.00%> (-46.91%) ⬇️
pl_bolts/models/rl/common/agents.py 0.00% <0.00%> (-100.00%) ⬇️
pl_bolts/models/rl/dueling_dqn_model.py 0.00% <0.00%> (-100.00%) ⬇️
...l_bolts/models/rl/vanilla_policy_gradient_model.py 0.00% <0.00%> (-96.37%) ⬇️
pl_bolts/models/rl/double_dqn_model.py 0.00% <0.00%> (-95.66%) ⬇️
pl_bolts/models/rl/common/gym_wrappers.py 0.00% <0.00%> (-91.60%) ⬇️
pl_bolts/models/rl/reinforce_model.py 0.00% <0.00%> (-89.35%) ⬇️
pl_bolts/models/rl/common/networks.py 0.00% <0.00%> (-89.25%) ⬇️
pl_bolts/models/rl/__init__.py 0.00% <0.00%> (-88.89%) ⬇️
pl_bolts/models/rl/per_dqn_model.py 0.00% <0.00%> (-86.67%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3187d...f1d7cc5. Read the comment docs.

@ydcjeff ydcjeff changed the title change to Any for batch argument change to type Any for batch argument Jan 4, 2021
@Borda Borda merged commit 055bfff into Lightning-Universe:master Jan 4, 2021
@ydcjeff ydcjeff deleted the batch-Any branch January 4, 2021 14:14
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants