-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code formatter yapf
to the tests and pre-commit
#509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 79.58% 79.07% -0.51%
==========================================
Files 102 102
Lines 5921 5921
==========================================
- Hits 4712 4682 -30
- Misses 1209 1239 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yapf
yapf
to the tests and pre-commit
Applied |
What does this PR do?
Adds
yapf
https://github.com/google/yapf to CI and pre-commit hooks and is part of #482.TODO
yapf
to pre-commit hooksyapf
to GitHub Actionsflake8
andisort
configs to avoid conflicts withyapf
yapf
to other files than pl_bolts/ and tests/.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃