Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link for cifar-10 weights #686

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Fix link for cifar-10 weights #686

merged 2 commits into from
Jul 13, 2021

Conversation

ananyahjha93
Copy link
Contributor

@ananyahjha93 ananyahjha93 commented Jul 12, 2021

What does this PR do?

Fixes the link to cifar-10 weights for simclr.

Fixes #658

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #686 (8998d50) into master (0505367) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   72.24%   72.24%           
=======================================
  Files         119      119           
  Lines        7356     7356           
=======================================
  Hits         5314     5314           
  Misses       2042     2042           
Flag Coverage Δ
cpu 72.24% <ø> (ø)
pytest 72.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0505367...8998d50. Read the comment docs.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@ananyahjha93 ananyahjha93 enabled auto-merge (squash) July 12, 2021 20:40
@ananyahjha93 ananyahjha93 requested review from ethanwharris and removed request for ethanwharris July 12, 2021 20:42
@Borda Borda disabled auto-merge July 13, 2021 09:12
@Borda Borda merged commit ab801aa into master Jul 13, 2021
@Borda Borda deleted the fix/weights_link branch July 13, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimCLR cifar-10 pretrained model url is not correct
4 participants