-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pin_memory=True
, shuffle=True
and num_workers=0
by default
#701
Conversation
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
===========================================
+ Coverage 24.83% 71.48% +46.64%
===========================================
Files 119 119
Lines 7332 7332
===========================================
+ Hits 1821 5241 +3420
+ Misses 5511 2091 -3420
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The failing tests are irrelevant to the change in this PR. |
What does this PR do?
This change has been suggested in #676 (comment).
This PR changes the default values of datamodules to:
pin_memory=True
shuffle=True
num_workers=0
(Same as the default value ofDataloader
in PyTorch: https://pytorch.org/docs/stable/data.html)Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃