Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pin_memory=True, shuffle=True and num_workers=0 by default #701

Merged
merged 5 commits into from
Aug 13, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Aug 11, 2021

What does this PR do?

This change has been suggested in #676 (comment).

This PR changes the default values of datamodules to:

Before submitting

  • [Add EMNISTDataModule #676] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #701 (da383b9) into master (fb558d1) will increase coverage by 46.64%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #701       +/-   ##
===========================================
+ Coverage   24.83%   71.48%   +46.64%     
===========================================
  Files         119      119               
  Lines        7332     7332               
===========================================
+ Hits         1821     5241     +3420     
+ Misses       5511     2091     -3420     
Flag Coverage Δ
cpu 71.48% <ø> (+46.64%) ⬆️
pytest 71.48% <ø> (+46.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datasets/imagenet_dataset.py 19.65% <0.00%> (+1.15%) ⬆️
pl_bolts/datasets/kitti_dataset.py 34.61% <0.00%> (+1.92%) ⬆️
pl_bolts/callbacks/vision/confused_logit.py 26.02% <0.00%> (+4.10%) ⬆️
pl_bolts/callbacks/printing.py 71.18% <0.00%> (+6.77%) ⬆️
pl_bolts/models/rl/common/cli.py 11.76% <0.00%> (+11.76%) ⬆️
pl_bolts/models/self_supervised/amdim/datasets.py 56.89% <0.00%> (+12.06%) ⬆️
pl_bolts/optimizers/lr_scheduler.py 80.48% <0.00%> (+12.19%) ⬆️
pl_bolts/callbacks/byol_updates.py 68.18% <0.00%> (+22.72%) ⬆️
...s/models/detection/components/_supported_models.py 100.00% <0.00%> (+28.57%) ⬆️
pl_bolts/models/detection/faster_rcnn/backbones.py 92.30% <0.00%> (+30.76%) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb558d1...da383b9. Read the comment docs.

@github-actions github-actions bot added the datamodule Anything related to datamodules label Aug 11, 2021
@akihironitta akihironitta added the enhancement New feature or request label Aug 11, 2021
@akihironitta akihironitta marked this pull request as ready for review August 11, 2021 09:13
@akihironitta akihironitta marked this pull request as draft August 11, 2021 09:13
@akihironitta akihironitta mentioned this pull request Aug 11, 2021
21 tasks
@akihironitta
Copy link
Contributor Author

The failing tests are irrelevant to the change in this PR.

@akihironitta akihironitta marked this pull request as ready for review August 12, 2021 05:41
@Borda Borda merged commit 2d7ae88 into master Aug 13, 2021
@Borda Borda deleted the feat/dm-default-args branch August 13, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants