Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for GPU tests #714

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Add fixes for GPU tests #714

merged 1 commit into from
Aug 27, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Aug 27, 2021

What does this PR do?

Attempt to try get GPU tests green!

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #714 (2286093) into master (47eb2aa) will increase coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
+ Coverage   72.17%   72.82%   +0.64%     
==========================================
  Files         121      121              
  Lines        7550     7550              
==========================================
+ Hits         5449     5498      +49     
+ Misses       2101     2052      -49     
Flag Coverage Δ
cpu 72.82% <100.00%> (+0.64%) ⬆️
pytest 72.82% <100.00%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/callbacks/verification/base.py 100.00% <100.00%> (ø)
pl_bolts/models/rl/advantage_actor_critic_model.py 97.70% <100.00%> (ø)
pl_bolts/models/rl/dqn_model.py 80.44% <100.00%> (ø)
pl_bolts/models/rl/reinforce_model.py 89.39% <100.00%> (ø)
...l_bolts/models/rl/vanilla_policy_gradient_model.py 93.44% <100.00%> (ø)
pl_bolts/datasets/mnist_dataset.py 87.50% <0.00%> (-4.17%) ⬇️
..._bolts/models/self_supervised/moco/moco2_module.py 59.42% <0.00%> (ø)
...l_bolts/models/self_supervised/byol/byol_module.py 51.06% <0.00%> (+28.72%) ⬆️
pl_bolts/callbacks/byol_updates.py 100.00% <0.00%> (+31.81%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47eb2aa...2286093. Read the comment docs.

@Borda Borda merged commit 4046278 into master Aug 27, 2021
@Borda Borda deleted the ci/fix_gpu_tests branch August 27, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants